MWPW-190616: UI follow-up for grouped variation translation#740
Open
mirafedas wants to merge 43 commits into
Open
MWPW-190616: UI follow-up for grouped variation translation#740mirafedas wants to merge 43 commits into
mirafedas wants to merge 43 commits into
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
Commits
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #740 +/- ##
==========================================
- Coverage 87.99% 87.96% -0.04%
==========================================
Files 221 221
Lines 65293 65307 +14
==========================================
- Hits 57457 57448 -9
- Misses 7836 7859 +23
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
…tion references Adds a new Adobe I/O Runtime action that scans all non-en_US fragments and removes variation references that are invalid — either wrong language or out-of-region — using cursor-based folder listing and PUT for the variations field (required due to live relationships). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…try handling - 21 tests covering getValidVariationsLocales, dryRun detection, live PUT writes, 429 retry backoff, 404 skip, folder listing errors, and scope filtering - Reduce batch concurrency from 10 to 3 to avoid rate limiting - Add exponential backoff retry (up to 3x) on 429 responses for both folder listing and individual fragment fetches Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ove localeFromPath to common - Extract 315-line inlined locale data to io/studio/src/locales.json (importable by CJS and ESM) - Move localeFromPath and export PATH_TOKENS from common.js (removes duplicate regex) - Fix Prettier violations in index.test.js and cleanup-variations/index.js Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Axelcureno
approved these changes
May 4, 2026
Member
Axelcureno
left a comment
Axelcureno
left a comment
There was a problem hiding this comment.
Both blockers resolved (SSRF + PATH_TOKENS). The console.warn is minor — ship it.
npeltier
requested changes
May 7, 2026
Contributor
npeltier
left a comment
npeltier
left a comment
There was a problem hiding this comment.
sorry Myra, but we shouldn't add io changes (esp. of that magnitude) together with other changes. Can you eventually track what looks like an improvement in a separate ticket, and leave that one with only UI changes?
loadOfferData had no fallbackWcsOsi support, and three callers passed the signal as the options object (broken signature), making the parent OSI fallback silently dead. Grouped variations have no osi field of their own — they need to fall back to the parent card's OSI to resolve offer data. - Add fallbackWcsOsi option to loadOfferData - Fix loadGroupedVariations / loadCardVariations / fetchVariationByPath to look up parent card OSI and pass it as fallback - Fix loadOfferDataForViewOnlyCard broken call signatures - Remove dead enrichGroupedVariationsWithOffers (never called, also broken) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves https://jira.corp.adobe.com/browse/MWPW-190616
AC 1:
These changes are covered with unit and Nala tests.
AC 2: variations render properly, so no changes made.
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases
Please do the steps below before submitting your PR for a code review or QA
🧪 Nala E2E Tests
Nala tests run automatically when you open this PR.
To run Nala tests again:
run nalalabel to this PR (in the right sidebar)To stop automatic Nala tests:
run nalalabelTest URLs: